From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S934504AbXGXIoi@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934504AbXGXIoi (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 Jul 2007 04:44:38 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758059AbXGXIo3
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 24 Jul 2007 04:44:29 -0400
Received: from mx2.suse.de ([195.135.220.15]:47138 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754666AbXGXIo3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 Jul 2007 04:44:29 -0400
Date: Tue, 24 Jul 2007 01:46:54 -0700
From: Greg KH <gregkh@suse.de>
To: Cornelia Huck <cornelia.huck@de.ibm.com>,
       Kay Sievers <kay.sievers@vrfy.org>
Cc: Simon Arlott <simon@fire.lp0.eu>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sysfs/udev broken in latest git?
Message-ID: <20070724084654.GB13152@suse.de>
References: <46A59EAA.9030105@simon.arlott.org.uk> <20070724072540.GA835@suse.de> <20070724100314.3c606131@gondolin.boeblingen.de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070724100314.3c606131@gondolin.boeblingen.de.ibm.com>
User-Agent: Mutt/1.5.15 (2007-04-06)
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 24, 2007 at 10:03:14AM +0200, Cornelia Huck wrote:
> On Tue, 24 Jul 2007 00:25:40 -0700,
> Greg KH <gregkh@suse.de> wrote:
> 
> > On Tue, Jul 24, 2007 at 07:39:38AM +0100, Simon Arlott wrote:
> > > The following commit appears to break some of my udev rules (I don't 
> > > have the time to finish the bisect right now, but there's only four 
> > > changes showing in "git bisect visualize" - this one is tagged 
> > > bisect/bad, and the other three are docs/docs/unrelated).
> > > 
> > > Neither of these symlinks get created by udev on kernels marked bad 
> > > (see bisect log below):
> > > 
> > > ACTION=="add", \
> > >         KERNEL=="event*", \
> > >         SUBSYSTEM=="input", \
> > >         SYSFS{description}=="i8042 KBD port", \
> > >         NAME="input/%k", \
> > >         SYMLINK="input/i8042-kbd", \
> > >         MODE="0640", \
> > >         GROUP="event"
> > > 
> > > ACTION=="add", \
> > >         KERNEL=="event*", \
> > >         SUBSYSTEM=="input", \
> > >         SYSFS{manufacturer}=="Logitech", \
> > >         SYSFS{product}=="USB-PS/2 Optical Mouse", \
> > >         NAME="input/%k", \
> > >         SYMLINK="input/logitech-mouse", \
> > >         MODE="0640", \
> > >         GROUP="event"
> 
> > Ugh, I thought this was all fixed up properly :(
> 
> I thought this as well :(
> 
> But I'm a bit confused: The patch in git has
> 
> +       /* only bus-device parents get a "device"-link */
> +       if (dev->parent && dev->parent->bus) {
> +               error = sysfs_create_link(&dev->kobj, &dev->parent->kobj,
> +                                         "device");
> 
> and
> 
> -               if (parent) {
> -                       sysfs_create_link(&dev->kobj, &dev->parent->kobj,
> -                                                       "device");
> 
> which really look like two different things. (My original patch didn't
> have the check for the parent's bus.) Don't know what happened here :(

Ugh, this might be a merge issue with Kay's block layer device work that
was in my tree, but I had to merge by hand around this area.

> (Simon: Do the links reappear if you change
> 	if (dev->parent && dev->parent->bus)
> to
> 	if (dev->parent)
> in device_add_class_symlinks()?)

Yeah, that would be good to find out.

Kay, did I mess up the merge here?

thanks,

greg k-h