From: Al Viro <viro@ftp.linux.org.uk>
To: Brandon Philips <bphilips@suse.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][RFC] Update net core to use devres.
Date: Wed, 25 Jul 2007 02:23:15 +0100 [thread overview]
Message-ID: <20070725012315.GX21668@ftp.linux.org.uk> (raw)
In-Reply-To: <20070724233007.GW21668@ftp.linux.org.uk>
On Wed, Jul 25, 2007 at 12:30:07AM +0100, Al Viro wrote:
> On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote:
> > Could you point me to an example you have in mind?
> >
> > I quickly searched through a handful of the PCI device drivers and
> > couldn't find an example where the .remove function didn't do something
> > to the tune of:
> >
> > unregister_netdev(dev);
> > ... various un-allocs and cleanup ...
> > free_netdev(dev)
>
> Now find the definition of free_netdev() and read it through, please.
PS: free_netdev() is certainly a bad name for that; the reasons are
mostly historical, since it used to free the damn thing. When that
became impossible (read: previous time net_device has meat device
model; consequences had not been pretty), the patch series from hell
had been big enough without renaming that one on top of everything else.
next prev parent reply other threads:[~2007-07-25 1:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 22:39 [PATCH 0/2][RFC] Update network drivers to use devres bphilips
2007-07-24 22:39 ` [PATCH 1/2][RFC] Update net core " bphilips
2007-07-24 22:51 ` Al Viro
2007-07-24 23:09 ` Al Viro
2007-07-24 23:26 ` Brandon Philips
2007-07-24 23:30 ` Al Viro
2007-07-25 1:23 ` Al Viro [this message]
2007-07-24 23:42 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725012315.GX21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bphilips@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.