All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Jens Axboe <jens.axboe@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
Date: Wed, 25 Jul 2007 13:04:56 +0200	[thread overview]
Message-ID: <200707251304.56505.bzolnier@gmail.com> (raw)
In-Reply-To: <20070725072354.GA18706@linux-sh.org>


Hi,

On Wednesday 25 July 2007, Paul Mundt wrote:
> BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> errors, starting with a parse error on the request_queue_t definition.
> Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> option back in to the block.
> 
> Caught with a randconfig on sh.

also pointed out in my bsg review from a week ago ;)

http://lkml.org/lkml/2007/7/17/487

> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Thanks for fixing this up.

Bart

  parent reply	other threads:[~2007-07-25 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25  7:23 [PATCH] bsg: Fix build for CONFIG_BLOCK=n Paul Mundt
2007-07-25  7:26 ` Jens Axboe
2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz [this message]
2007-07-26 10:51   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707251304.56505.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.