From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
David Miller <davem@davemloft.net>,
hpa@zytor.com, kaos@ocs.com.au, xyzzy@speakeasy.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH][RFC] getting rid of stupid loop in BUG()
Date: Wed, 25 Jul 2007 18:25:42 +0100 [thread overview]
Message-ID: <20070725172542.GG27237@ftp.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.0.999.0707251018280.3607@woody.linux-foundation.org>
On Wed, Jul 25, 2007 at 10:19:55AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 25 Jul 2007, Jeremy Fitzhardinge wrote:
> >
> > No, not any more. The file and line info is out of line, in a separate
> > section, indexed by the ud2a's eip.
>
> That's irrelevant - the point is, we need to do the ud2 by hand, since we
> need to control the code generation in order to associate the ud2 with the
> proper file/linenr.
>
> > The main problem with __builtin_trap is that there's no certain way to
> > get the actual ud2a eip (ie, paste an asm label onto it).
>
> Right. Which is why we need to do it as an inline asm.
Who said that we need to populate that section from asm? Define
a static variable in that section inside a block; identifier is
not a problem, obviously.
I'm not saying that it's not revolting, but it's not impossible.
next prev parent reply other threads:[~2007-07-25 17:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 15:39 [PATCH][RFC] getting rid of stupid loop in BUG() Al Viro
2007-07-24 16:56 ` Jeremy Fitzhardinge
2007-07-24 17:03 ` H. Peter Anvin
2007-07-24 17:14 ` Al Viro
2007-07-24 17:28 ` H. Peter Anvin
2007-07-24 18:58 ` Jeremy Fitzhardinge
2007-07-24 19:01 ` H. Peter Anvin
2007-07-24 19:13 ` Jeremy Fitzhardinge
2007-07-24 20:04 ` Al Viro
2007-07-24 21:14 ` Jeremy Fitzhardinge
2007-07-25 2:31 ` Trent Piepho
2007-07-25 2:50 ` Keith Owens
2007-07-25 5:09 ` H. Peter Anvin
2007-07-25 6:24 ` Jeremy Fitzhardinge
2007-07-25 6:29 ` David Miller
2007-07-25 6:50 ` Heiko Carstens
2007-07-25 16:56 ` Linus Torvalds
2007-07-25 17:00 ` Jeremy Fitzhardinge
2007-07-25 17:03 ` H. Peter Anvin
2007-07-25 17:19 ` Linus Torvalds
2007-07-25 17:25 ` Al Viro [this message]
2007-07-25 17:36 ` Jeremy Fitzhardinge
2007-07-25 19:35 ` David Miller
2007-07-25 20:26 ` H. Peter Anvin
2007-07-25 19:28 ` David Miller
2007-07-25 17:19 ` Al Viro
2007-07-25 17:22 ` H. Peter Anvin
2007-07-25 17:26 ` Al Viro
2007-07-25 17:35 ` David Howells
2007-07-25 17:41 ` Jeremy Fitzhardinge
2007-07-25 20:29 ` Chuck Ebbert
2007-07-25 20:37 ` H. Peter Anvin
2007-07-25 22:01 ` David Miller
2007-07-25 18:24 ` Linus Torvalds
2007-07-25 17:36 ` Al Viro
2007-07-25 17:44 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725172542.GG27237@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=kaos@ocs.com.au \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.