From: Andrew Morton <akpm@linux-foundation.org>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
"Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH 03/33] s3c2410fb: fix s3c2410 compilation
Date: Thu, 26 Jul 2007 13:02:53 -0700 [thread overview]
Message-ID: <20070726130253.1b847edc.akpm@linux-foundation.org> (raw)
In-Reply-To: <46A889ED.1020304@gmail.com>
On Thu, 26 Jul 2007 19:47:57 +0800 "Antonino A. Daplas" <adaplas@gmail.com> wrote:
> @@ -680,6 +681,7 @@ static inline void modify_gpio(void __io
> static int s3c2410fb_init_registers(struct s3c2410fb_info *fbi)
> {
> unsigned long flags;
> + void __iomem *regs = fbi->io;
>
> /* Initialise LCD with values from haret */
>
> @@ -694,25 +696,25 @@ static int s3c2410fb_init_registers(stru
>
> local_irq_restore(flags);
What are the local_irq_save/restore calls in this driver doing?
Either something subtle is happening, or it is wrong on SMP. If it's an
only-ever-on-UP driver then spin_lock_irqsave() would be better: it'll
deveolve to local_irq_save() anyway.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-07-26 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 11:47 [PATCH 03/33] s3c2410fb: fix s3c2410 compilation Antonino A. Daplas
2007-07-26 20:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726130253.1b847edc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=ben-linux@fluff.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.