From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Josh Triplett <josht@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces.
Date: Thu, 26 Jul 2007 17:35:01 -0700 [thread overview]
Message-ID: <20070726173501.9ba466ba.akpm@linux-foundation.org> (raw)
In-Reply-To: <m3abtir95x.fsf@maximus.localdomain>
On Fri, 27 Jul 2007 02:18:34 +0200 Krzysztof Halasa <khc@pm.waw.pl> wrote:
> Josh Triplett <josht@linux.vnet.ibm.com> writes:
>
> > +This also does not apply to a do-while loop; always use braces with a do-while,
> > +even if it contains a single statement:
>
> I can't see anything wrong with
>
> do
> abc;
> while (xyz);
>
Me either, but whatever.
> and even if I could, "always use" seems way too strong in this case.
it's better that we all do things the same way. What that way _is_ is
actually less important, unless it's something stupid, of course.
In this case, most of the code I've seen uses the braces (I think).
next prev parent reply other threads:[~2007-07-27 0:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 21:37 [PATCH] CodingStyle: proscribe do-while without braces Josh Triplett
2007-07-26 21:44 ` Andrew Morton
2007-07-26 21:54 ` Josh Triplett
2007-07-27 0:18 ` Krzysztof Halasa
2007-07-27 0:35 ` Andrew Morton [this message]
2007-07-27 16:00 ` Krzysztof Halasa
2007-07-27 17:05 ` Josh Triplett
2007-07-27 17:44 ` Krzysztof Halasa
2007-07-27 18:27 ` Andrew Morton
2007-07-27 18:52 ` Josh Triplett
2007-07-27 0:42 ` Stefan Richter
2007-07-27 0:59 ` Andrew Morton
2007-07-27 7:41 ` Stefan Richter
2007-07-27 7:53 ` Andrew Morton
2007-07-27 17:13 ` Stefan Richter
2007-07-27 1:17 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726173501.9ba466ba.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=josht@linux.vnet.ibm.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.