From: Al Viro <viro@ftp.linux.org.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockd and nfsd endianness annotation fixes
Date: Fri, 27 Jul 2007 02:38:35 +0100 [thread overview]
Message-ID: <20070727013835.GR27237@ftp.linux.org.uk> (raw)
In-Reply-To: <20070727011922.GC27538@fieldses.org>
On Thu, Jul 26, 2007 at 09:19:22PM -0400, J. Bruce Fields wrote:
> Thanks, uh, I probably saw that message too.
>
> Hm, trying it just now--it catches the svclock.c mistake, but not the
> one in nfsd/nfs4xdr.c--at least not as far as I can tell.
fs/nfsd/nfs4xdr.c:2659:32: warning: incorrect type in argument 2 (different base types)
fs/nfsd/nfs4xdr.c:2659:32: expected int [signed] nfserr
fs/nfsd/nfs4xdr.c:2659:32: got restricted unsigned int [usertype] status
is what got triggered. I.e. call in
case OP_SECINFO:
nfsd4_encode_secinfo(resp, op->status, &op->u.secinfo);
break;
which pointed to the misannotated function...
prev parent reply other threads:[~2007-07-27 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 16:33 [PATCH] lockd and nfsd endianness annotation fixes Al Viro
2007-07-26 22:08 ` J. Bruce Fields
2007-07-27 0:11 ` Neil Brown
2007-07-27 1:19 ` J. Bruce Fields
2007-07-27 1:38 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070727013835.GR27237@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.