From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Dike Date: Fri, 27 Jul 2007 16:35:41 +0000 Subject: Re: [PATCH 18/68] 0 -> NULL, for arch/um Message-Id: <20070727163541.GA6930@c2.user-mode-linux.org> List-Id: References: <200707270945.LAA17372@ifs.emn.fr> In-Reply-To: <200707270945.LAA17372@ifs.emn.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yoann Padioleau Cc: kernel-janitors@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, akpm@linux-foundation.org, linux-kernel@vger.kernel.org On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote: > When comparing a pointer, it's clearer to compare it to NULL than to 0. ACK > sys-i386/fault.c | 2 +- > sys-x86_64/fault.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Except you should probably diff from the top of the kernel tree. Jeff -- Work email - jdike at linux dot intel dot com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IESnO-00060m-2V for user-mode-linux-devel@lists.sourceforge.net; Fri, 27 Jul 2007 09:36:06 -0700 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IESnL-0004Hx-1T for user-mode-linux-devel@lists.sourceforge.net; Fri, 27 Jul 2007 09:36:06 -0700 Date: Fri, 27 Jul 2007 12:35:41 -0400 From: Jeff Dike Message-ID: <20070727163541.GA6930@c2.user-mode-linux.org> References: <200707270945.LAA17372@ifs.emn.fr> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <200707270945.LAA17372@ifs.emn.fr> Subject: Re: [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Yoann Padioleau Cc: akpm@linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote: > When comparing a pointer, it's clearer to compare it to NULL than to 0. ACK > sys-i386/fault.c | 2 +- > sys-x86_64/fault.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Except you should probably diff from the top of the kernel tree. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937354AbXG0QgT (ORCPT ); Fri, 27 Jul 2007 12:36:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934631AbXG0QgM (ORCPT ); Fri, 27 Jul 2007 12:36:12 -0400 Received: from [198.99.130.12] ([198.99.130.12]:52692 "EHLO saraswathi.solana.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S934570AbXG0QgL (ORCPT ); Fri, 27 Jul 2007 12:36:11 -0400 Date: Fri, 27 Jul 2007 12:35:41 -0400 From: Jeff Dike To: Yoann Padioleau Cc: kernel-janitors@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/68] 0 -> NULL, for arch/um Message-ID: <20070727163541.GA6930@c2.user-mode-linux.org> References: <200707270945.LAA17372@ifs.emn.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200707270945.LAA17372@ifs.emn.fr> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote: > When comparing a pointer, it's clearer to compare it to NULL than to 0. ACK > sys-i386/fault.c | 2 +- > sys-x86_64/fault.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Except you should probably diff from the top of the kernel tree. Jeff -- Work email - jdike at linux dot intel dot com