From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [2.6 patch] let SUSPEND select HOTPLUG_CPU Date: Sat, 28 Jul 2007 01:03:07 +0200 Message-ID: <20070727230307.GC15129@stusta.de> References: <200707251238.50218.lenb@kernel.org> <200707262117.26353.rjw@sisk.pl> <200707262248.09187.rjw@sisk.pl> <20070727222503.GB15129@stusta.de> <46AA7609.1040900@s5r6.in-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mailout.stusta.mhn.de ([141.84.69.5]:46957 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761029AbXG0XDf (ORCPT ); Fri, 27 Jul 2007 19:03:35 -0400 Content-Disposition: inline In-Reply-To: <46AA7609.1040900@s5r6.in-berlin.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Stefan Richter Cc: Linus Torvalds , "Rafael J. Wysocki" , Len Brown , david@lang.hm, Andrew Morton , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek On Sat, Jul 28, 2007 at 12:47:37AM +0200, Stefan Richter wrote: > Adrian Bunk wrote: > > The dependency of SUSPEND_SMP on HOTPLUG_CPU is quite unintuitive, > > It's not entirely unintuitive. That option's full name is "Support for > suspend on SMP and hot-pluggable CPUs". > > Only the place where you find the option is unintuitive, as far as its > first application is concerned. (It lives in the "Processor type and > features" menu which is OK for the 2nd application of this option.) And > the variable name of that option is unintuitive because it covers only > the 2nd application of the option, I suppose for historical reasons. We can figure out ourselves when HOTPLUG_CPU is required, so there's no reason to bother the user with it. > > +config SUSPEND_SMP_POSSIBLE > > + bool > > + depends on (X86 && !X86_VOYAGER) || (PPC64 && (PPC_PSERIES || PPC_PMAC)) > > + depends on SMP > > + default y > > + > > +config SUSPEND_SMP > > + bool > > + depends on SUSPEND_SMP_POSSIBLE && SOFTWARE_SUSPEND > > + select HOTPLUG_CPU > > + default y > > Yes, that's the price to pay if you want to select something that in > turn depends on a number of other things. Yes, but a good user interface is worth it. > Wait, doesn't HOTPLUG_CPU also depend on EXPERIMENTAL? Damn, I started thinking about it, and then forgot about it when finishing the patch. My thoughts were: Is HOTPLUG_CPU still an experimental feature, or has it become a well-tested no longer experimental feature now that it's used on most recent laptops? > Stefan Richter cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed