All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Subbu Seetharaman" <subbus@serverengines.com>
To: "Jan Engelhardt" <jengelh@computergmbh.de>,
	"Chris Friesen" <cfriesen@nortel.com>,
	alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: Source organization for two drivers sharing coomon code
Date: Fri, 27 Jul 2007 19:42:55 -0700	[thread overview]
Message-ID: <20070728024255.af17c314@mailhost.serverengines.com> (raw)
In-Reply-To: Pine.LNX.4.64.0707272131270.16356@fbirervta.pbzchgretzou.qr

Thanks for all the answers.  The common code is mostly handling
the message passing for hardware  initialization, rings creation
and some ioctls.  drivers/message looks like a good place for this
code to live.

Subbu



From: Jan Engelhardt [mailto:jengelh@computergmbh.de]
To: Chris Friesen [mailto:cfriesen@nortel.com]
Cc: Subbu Seetharaman [mailto:subbus@serverengines.com], linux-kernel@vger.kernel.org
Sent: Fri, 27 Jul 2007 12:34:16 -0700
Subject: Re: Source organization for two drivers sharing coomon code


On Jul 27 2007 13:12, Chris Friesen wrote:
> Jan Engelhardt wrote:
>> On Jul 27 2007 10:17, Subbu Seetharaman wrote:
>> 
>> >What is the recommended way for two drivers to share common code ?
>> ><snip>...The source code for these dirvers will fit under drivers/net and
>> >drivers/scsi. But both drivers share some common code.
>
>> You could create (in total) three modules, e.g. my-common.ko,
>> my-net.ko and my-scsi.ko, of which the latter two use functions from the
>> first.
>
> Where would the common code live, in such a case? Would you just pick one of
> the two locations at random, or put it in drivers/misc or maybe lib?

Perhaps drivers/message - well I can't answer that exactly.

As far as the output object files are concerned, it is not relevant,
since they will be autoloaded anyway :)



Jan
-- 

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines LLC and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.


             reply	other threads:[~2007-07-28  2:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-28  2:42 Subbu Seetharaman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-27 17:17 Source organization for two drivers sharing coomon code Subbu Seetharaman
2007-07-27 17:35 ` Alan Cox
2007-07-27 19:03 ` Jan Engelhardt
2007-07-27 19:12   ` Chris Friesen
2007-07-27 19:34     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070728024255.af17c314@mailhost.serverengines.com \
    --to=subbus@serverengines.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cfriesen@nortel.com \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.