From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: do_generic_mapping_read abuse in gfs2 Date: Sat, 28 Jul 2007 19:42:38 +0200 Message-ID: <20070728174238.GA5805@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org To: swhiteho@redhat.com Return-path: Received: from verein.lst.de ([213.95.11.210]:41086 "EHLO mail.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035AbXG1Rmm (ORCPT ); Sat, 28 Jul 2007 13:42:42 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org I was looking into cleaning up the the read actor mess now that sendfile uses splice and notices gfs2 now uses do_generic_mapping_read. The use is rather odd because it's used for reading small structures from kernelspace and thus doesn't actually needs the fullblown do_generic_mapping_read at all. Any chance you could switch it to a simple read_cache_page() so we can kill do_generic_mapping_read?