From mboxrd@z Thu Jan 1 00:00:00 1970 From: maximilian attems Subject: [rfc/patch] ntfs reduce syslog noise Date: Sat, 28 Jul 2007 23:10:21 +0200 Message-ID: <20070728211021.GD4504@stro.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.ne To: aia21@cantab.net Return-path: Received: from baikonur.stro.at ([213.239.196.228]:3780 "EHLO baikonur.stro.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753696AbXG1VMs (ORCPT ); Sat, 28 Jul 2007 17:12:48 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org user complained on syslog spamming by NTFS-fs error (device hda7): ntfs_ucstonls(): Unicode name contains characters that cannot be converted to character set koi8-r. You might want to try to use the mount option nls=utf8. NTFS-fs warning (device hda7): ntfs_filldir(): Skipping unrepresentable inode 0x130cc. -> http://bugs.debian.org/351009 the custom ntfs loglevel are a pain as they encode the KERN_ERR printk level for any ntfs_warning() call belows patch tries to tame one of the 2 complaints. diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 34314b3..10cc8d9 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c @@ -1050,7 +1050,7 @@ static inline int ntfs_filldir(ntfs_volume *vol, loff_t fpos, ie->key.file_name.file_name_length, &name, NTFS_MAX_NAME_LEN * NLS_MAX_CHARSET_SIZE + 1); if (name_len <= 0) { - ntfs_warning(vol->sb, "Skipping unrepresentable inode 0x%llx.", + ntfs_debug(vol->sb, "Skipping unrepresentable inode 0x%llx.", (long long)MREF_LE(ie->data.dir.indexed_file)); return 0; }