From: David Miller <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH] v2.6.23-rc1 Sparc32 Serial Port Selection error
Date: Sun, 29 Jul 2007 09:09:07 +0000 [thread overview]
Message-ID: <20070729.020907.36925670.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0707290259060.28781@mtfhpc.demon.co.uk>
From: Mark Fortescue <mark@mtfhpc.demon.co.uk>
Date: Sun, 29 Jul 2007 09:42:00 +0100 (BST)
>
>
> On Sun, 29 Jul 2007, David Miller wrote:
>
> > From: Mark Fortescue <mark@mtfhpc.demon.co.uk>
> > Date: Sun, 29 Jul 2007 08:55:25 +0100 (BST)
> >
> >> Yes but then you do a !skip-- so 0 -> -1 and 1 -> 0
> >
> > Indeed. This is coded in a very non-intuitive manner. The code
> > selecting the string wants to use the original value of "skip", not
> > the one modified by the node traversal loop.
> >
> > Perhaps the following version of the fix is a little clearer.
> > What do you think?
> >
>
> This also has the advantage that if any sparc32 systems have more than the
> usual two serial console ports, they can be added in relativly easilly. I
> think SBUS serial card I currently have in my SS1 can provide another four
> serial ports for use as console ports, if I put it in the SS2 and write a
> linux driver for it (I have the NetBSD driver source but have not got
> around to porting it yet). The SS1 Prom has an issue with the FCode so the
> extar ports are not available.
Great, I'll put this version of the patch in then.
I also remember seeing several problems with older OBP implementations
in the older sun4c's. For example, they couldn't handle qe network
cards because they couldn't handle device hierarchies of SBUS devices
sitting underneath a SBUS device.
prev parent reply other threads:[~2007-07-29 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 2:17 [PATCH] v2.6.23-rc1 Sparc32 Serial Port Selection error Mark Fortescue
2007-07-29 5:53 ` David Miller
2007-07-29 6:43 ` David Miller
2007-07-29 7:55 ` Mark Fortescue
2007-07-29 8:00 ` David Miller
2007-07-29 8:42 ` Mark Fortescue
2007-07-29 9:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070729.020907.36925670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.