Re: [PATCH 15/23] mount.nfs: clean up getport() function

["J. Bruce Fields" <bfields@fieldses.org>]

On Sat, Jul 28, 2007 at 05:50:24PM -0400, Chuck Lever wrote:
> Mostly comment clarification.  Also replace some naked undocumented
> integers with macros, and make getport() static.
> @@ -153,25 +157,30 @@ unsigned short getport(struct sockaddr_in *saddr, unsigned long prog,
>  		return 0;
>  	}
>  
> -	switch (prot) {
> +	switch (proto) {
>  	case IPPROTO_UDP:
>  		clnt = clntudp_bufcreate(saddr,
> -					 PMAPPROG, PMAPVERS, TIMEOUT, &socket,
> -					 UDPMSGSIZE, UDPMSGSIZE);
> +					 PMAPPROG, PMAPVERS,
> +					 RETRY_TIMEOUT, &socket,
> +					 RPCSMALLMSGSIZE,
> +					 RPCSMALLMSGSIZE);
>  		break;
>  	case IPPROTO_TCP:
> -		clnt = clnttcp_create(saddr,
> -			PMAPPROG, PMAPVERS, &socket, 50, 500);
> +		clnt = clnttcp_create(saddr, PMAPPROG, PMAPVERS, &socket,
> +				      RPCSMALLMSGSIZE, RPCSMALLMSGSIZE);

Did you mean to change those final two arguments?  (They were different
before, then they're the same after.)

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs