All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Dave Jiang <djiang@mvista.com>
Cc: linuxppc-dev@ozlabs.org, bluesmoke-devel@lists.sourceforge.net,
	norsk5@yahoo.com
Subject: Re: [PATCH 2/2] powerpc: MPC85xx EDAC device driver
Date: Mon, 30 Jul 2007 21:58:15 +0200	[thread overview]
Message-ID: <200707302158.16530.arnd@arndb.de> (raw)
In-Reply-To: <46AE3C06.5060100@mvista.com>

On Monday 30 July 2007, Dave Jiang wrote:
> I don't believe that EDAC core has been loaded at the time of 85xx PCI
> initialization. Plus, the EDAC driver can be loaded as a kernel module. So that
> probably won't work....

ok, good point.

> Also, instead of having centralized EDAC chip driver, 
> now you have things scattered over various places. One probably needs to add
> 83xx and 86xx code as well and whatever else eventually.
> 
> Maybe we are just better off adding entries in the DTS to get around this
> problem....

The best solution may be to look at how it's structured at the
register level. If the PCI EDAC registers are implemented separately
from the regular PCI registers, a device tree entry would be appropriate.
If not, your idea of registering a platform_device from fsl_add_bridge
is probably more sensible.

	Arnd <><

  reply	other threads:[~2007-07-30 19:58 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26 22:22 [PATCH 2/2] powerpc: MPC85xx EDAC device driver Dave Jiang
2007-07-29 14:06 ` Arnd Bergmann
2007-07-30 16:40   ` Dave Jiang
2007-07-30 17:28     ` Arnd Bergmann
2007-07-30 17:48       ` Dave Jiang
2007-07-30 18:46         ` Arnd Bergmann
2007-07-30 19:29           ` Dave Jiang
2007-07-30 19:58             ` Arnd Bergmann [this message]
2007-07-30 20:17               ` Dave Jiang
2007-07-30 21:44                 ` Linas Vepstas
2007-07-30 22:47                   ` Doug Thompson
2007-08-01 19:48                     ` EDAC & PCI error recovery (was Re: [PATCH 2/2] powerpc: MPC85xx EDAC device driver) Linas Vepstas
2007-08-01 19:48                       ` Linas Vepstas
2007-08-01 20:34                       ` [ofa-general] Re: EDAC stats " Doug Thompson
2007-08-01 20:34                         ` Doug Thompson
2007-07-30 22:58                   ` [PATCH 2/2] powerpc: MPC85xx EDAC device driver Dave Jiang
2007-07-31 20:49               ` Dave Jiang
2007-07-31 22:07                 ` Arnd Bergmann
2007-07-31 22:24                   ` Dave Jiang
2007-07-31 22:25                     ` Arnd Bergmann
2007-08-01  0:16                       ` Dave Jiang
2007-08-01  8:36                         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707302158.16530.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=bluesmoke-devel@lists.sourceforge.net \
    --cc=djiang@mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=norsk5@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.