From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1IFsoY-0006my-LF
	for mharc-grub-devel@gnu.org; Tue, 31 Jul 2007 10:35:10 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IFsoX-0006ms-BU
	for grub-devel@gnu.org; Tue, 31 Jul 2007 10:35:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IFsoV-0006mP-1Y
	for grub-devel@gnu.org; Tue, 31 Jul 2007 10:35:08 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IFsoU-0006mM-Rf
	for grub-devel@gnu.org; Tue, 31 Jul 2007 10:35:06 -0400
Received: from aybabtu.com ([69.60.117.155])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1IFsoU-00027x-IA
	for grub-devel@gnu.org; Tue, 31 Jul 2007 10:35:06 -0400
Received: from [192.168.10.6] (helo=aragorn)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <rmh@aybabtu.com>)
	id 1IFsoS-0007Ag-8c; Tue, 31 Jul 2007 16:35:04 +0200
Received: from rmh by aragorn with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>)
	id 1IFsrg-0002Cp-1t; Tue, 31 Jul 2007 16:38:24 +0200
Date: Tue, 31 Jul 2007 16:38:24 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20070731143823.GA16557@aragorn>
References: <20070724195946.GA3336@aragorn>
	<fb412d760707251051u3b07dc32l1a5642fbee9bd8b4@mail.gmail.com>
	<20070725200805.GA17393@aragorn>
	<fb412d760707251625i4fff2a57w88bfde40feda76b6@mail.gmail.com>
	<20070727080500.GA17986@aragorn>
	<20070727103310.GA1539@powerlinux.fr>
	<20070727191514.GA3461@aragorn> <20070729193011.GA7033@aragorn>
	<20070730201138.GA27359@aragorn>
	<fb412d760707301535x501fe4c2qf2487dffc7c9c25d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb412d760707301535x501fe4c2qf2487dffc7c9c25d@mail.gmail.com>
Organization: free as in freedom
X-Message-Flag: Microsoft discourages use of Outlook.
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: Genre and OS details not recognized.
Cc: Sven Luther <sven@powerlinux.fr>
Subject: Re: [PATCH] efika memory issues
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Jul 2007 14:35:09 -0000

On Mon, Jul 30, 2007 at 05:35:28PM -0500, Hollis Blanchard wrote:
> >         When GRUB_IEEE1275_FLAG_EFIKA_SECRET_AVAILABLE_REGION was set,
> >         release hardcoded 0x4000:0xffc000 region.
> 
> Hmm, does this actually work? Since GRUB itself falls within that
> regions, the grub_ieee1275_release() call will mark all the memory
> that the GRUB kernel and modules occupy as free, which means they will
> be clobbered by heap usage.

Didn't think of this.. (by chance it worked here, though).  How about using
max(_end,0x4000) instead of 0x4000 ?

(and adjusting region length not to overflow 0x1000000)

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.