From: Michael Buesch <mb@bu3sch.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-wireless@vger.kernel.org, John Linville <linville@tuxdriver.com>
Subject: [PATCH] softmac: Fix deadlock of wx_set_essid with assoc work
Date: Tue, 31 Jul 2007 14:57:33 +0200 [thread overview]
Message-ID: <200707311457.33723.mb@bu3sch.de> (raw)
The essid wireless extension does deadlock against the assoc mutex,
as we don't unlock the assoc mutex.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
--
David, please test if this fixes your deadlock.
Index: bu3sch-wireless-dev/net/ieee80211/softmac/ieee80211softmac_wx.c
===================================================================
--- bu3sch-wireless-dev.orig/net/ieee80211/softmac/ieee80211softmac_wx.c 2007-03-05 18:42:18.000000000 +0100
+++ bu3sch-wireless-dev/net/ieee80211/softmac/ieee80211softmac_wx.c 2007-07-31 14:51:46.000000000 +0200
@@ -98,9 +98,12 @@ ieee80211softmac_wx_set_essid(struct net
cancel_delayed_work(&authptr->work);
sm->associnfo.bssvalid = 0;
sm->associnfo.bssfixed = 0;
- flush_scheduled_work();
sm->associnfo.associating = 0;
sm->associnfo.associated = 0;
+ /* Unlock mutex, otherwise we deadlock with the assoc work handler. */
+ mutex_unlock(&sm->associnfo.mutex);
+ flush_scheduled_work();
+ mutex_lock(&sm->associnfo.mutex);
}
}
--
Greetings Michael.
next reply other threads:[~2007-07-31 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 12:57 Michael Buesch [this message]
2007-07-31 15:01 ` [PATCH] softmac: Fix deadlock of wx_set_essid with assoc work David Woodhouse
2007-07-31 18:16 ` Michael Buesch
-- strict thread matches above, loose matches on Subject: below --
2007-08-07 10:02 Michael Buesch
2007-08-07 10:18 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707311457.33723.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.