All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Stefan Seyfried <seife@suse.de>,
	suspend-devel@lists.sourceforge.net,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [rft] Kill junk from s2ram resume paths
Date: Tue, 31 Jul 2007 16:58:21 +0200	[thread overview]
Message-ID: <20070731145821.GL2087@elf.ucw.cz> (raw)
In-Reply-To: <200707311703.44096.rjw@sisk.pl>

Hi!


> > > diff --git a/arch/i386/kernel/acpi/wakeup.S b/arch/i386/kernel/acpi/wakeup.S
> > > index 1415da1..9cebef7 100644
> > > --- a/arch/i386/kernel/acpi/wakeup.S
> > > +++ b/arch/i386/kernel/acpi/wakeup.S
> > > @@ -28,21 +28,6 @@ #define BEEP \
> > >  	movb	$15, %al; 	\
> > >  	outb	%al, $66;
> > >  
> > > -#define BEEP \
> > > -	inb	$97, %al; 	\
> > > -	outb	%al, $0x80; 	\
> > > -	movb	$3, %al; 	\
> > > -	outb	%al, $97; 	\
> > > -	outb	%al, $0x80; 	\
> > > -	movb	$-74, %al; 	\
> > > -	outb	%al, $67; 	\
> > > -	outb	%al, $0x80; 	\
> > > -	movb	$-119, %al; 	\
> > > -	outb	%al, $66; 	\
> > > -	outb	%al, $0x80; 	\
> > > -	movb	$15, %al; 	\
> > > -	outb	%al, $66;
> > > -
> > >  ALIGN
> > >  	.align	4096
> > >  ENTRY(wakeup_start)
> > 
> > This hunk rejected for me (against 2.6.23-rc1), but i'm testing x86_64, so
> > it did not matter ;-)
> 
> I think it's gone in favor of the more sophisticated beeping
> > > support.

No. It was merge problem on my side, I actually had _two_ times the
beeping macro.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2007-07-31 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31 12:12 [rft] Kill junk from s2ram resume paths Pavel Machek
2007-07-31 13:20 ` Rafael J. Wysocki
2007-07-31 13:18   ` Pavel Machek
2007-07-31 13:49     ` Rafael J. Wysocki
2007-07-31 14:01       ` Pavel Machek
2007-07-31 14:43         ` Stefan Seyfried
2007-07-31 15:03           ` Rafael J. Wysocki
2007-07-31 14:58             ` Pavel Machek [this message]
2007-08-01 21:10           ` Stefan Seyfried

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070731145821.GL2087@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=seife@suse.de \
    --cc=suspend-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.