Re: [PATCH 0/7] nfsstat: adding -D/--diff-stat to nfsstat

["J. Bruce Fields" <bfields@fieldses.org>]

On Wed, Aug 01, 2007 at 02:37:09PM -0400, david m. richter wrote:
> 	i think that zeroing all the counters is too much of a "big 
> hammer" approach to what was intended to be a quick and simple use-case.  
> if there's a kernel interface for zeroing stuff, then maybe that could be 
> added, too; someone should have-at.
> 
> 	thoughts, neil?

I think it was Steve that tried that a couple years ago.  I objected,
and feel like a bit of a jerk for it, because the fact is he did a fine
job of it as far as I could tell.

But I'd still object, for the same reasons; global zeroing of the in-kernel
stats is an operation that:

	- isn't friendly to concurrent processes gathering stats:
	  someone might want to run a cron job that summarizes the day's
	  nfs stats, but still be able to log in and get a quick
	  snapshot of current activity.
	- requires special privileges: you may be comfortable allowing
	  anyone to read the stats, but you probably won't allow anyone
	  to zero them.
	- requires a new kernel interface, when you could just do
	  everything in userspace and get something that works for free
	  on older kernels too....

But I think more snapshot-and-diff operations would be a fine idea.
And probably easy and fun to implement.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs