From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [patch 2.6.22-git5 3/4] MMC core learns about SPI Date: Thu, 2 Aug 2007 12:23:30 -0700 Message-ID: <200708021223.31355.david-b@pacbell.net> References: <200707141504.51950.david-b@pacbell.net> <200708011002.28801.david-b@pacbell.net> <20070802145445.1118d1e7@poseidon.drzeus.cx> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Hans-Peter Nilsson , Mikael Starvik , Mike Lavender , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Pierre Ossman Return-path: In-Reply-To: <20070802145445.1118d1e7-mgABNEgzgxm+PRNnhPf8W5YgPPQkE1Si@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thursday 02 August 2007, Pierre Ossman wrote: > = > > So, move the param and mmc_spi_set_crc() into core.c then, and > > leave the calls where they are? > > = > = > mmc_spi_set_crc() fits quite nicely into mmc_ops.c, so no need for > moving that. I was thinking more along the lines of: > = > extern int mmc_spi_crc_enabled; > = > mmc_spi_set_crc(host, mmc_spi_crc_enabled); OK. > > Can we do that as a separate patch? =A0You said below we can proceed, > > which suggests to me that now's the time to convert to incrmentals. > > I don't mind a few more update patches, but it'd be easier to do > > them against say a git-mmc patch against 2.6.23-rc2 ... > > = > = > Sure. > = ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/