From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: [-mm patch] CPU_FREQ_GOV_PERFORMANCE must always be y Date: Thu, 2 Aug 2007 15:48:38 +0200 Message-ID: <20070802134838.GV3972@stusta.de> References: <20070801165704.a26961b7.akpm@linux-foundation.org> <46B12516.4090006@googlemail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <46B12516.4090006@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Gabriel C , davej@codemonkey.org.uk Cc: Andrew Morton , Miles Lane , LKML , Thomas Renninger , cpufreq@lists.linux.org.uk On Thu, Aug 02, 2007 at 02:28:06AM +0200, Gabriel C wrote: > Andrew Morton wrote: > > On Wed, 1 Aug 2007 16:31:46 -0700 > > "Miles Lane" wrote: > > > >> LD .tmp_vmlinux1 > >> drivers/built-in.o: In function `__cpufreq_governor': > >> cpufreq.c:(.text+0xaf178): undefined reference to `cpufreq_gov_performance' > >> cpufreq.c:(.text+0xaf18a): undefined reference to `cpufreq_gov_performance' > >> make: *** [.tmp_vmlinux1] Error 1 > > > > One for Thomas, I expect. > > Is this patch : > > cpufreq-allow-ondemand-and-conservative-cpufreq-governors-to-be-used-as-default.patch > > Reverting it here fixes the error. Possible fix below. > Gabriel cu Adrian <-- snip --> With the 'performance' governor always as a fallback it must always be compiled into the kernel. Signed-off-by: Adrian Bunk --- drivers/cpufreq/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) d7418849ec236338ec5ac74c0d66e5aaae466ffe diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 721f86f..91f7cfd 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -84,7 +84,6 @@ config CPU_FREQ_DEFAULT_GOV_USERSPACE config CPU_FREQ_DEFAULT_GOV_ONDEMAND bool "ondemand" select CPU_FREQ_GOV_ONDEMAND - select CPU_FREQ_GOV_PERFORMANCE help Use the CPUFreq governor 'ondemand' as default. This allows you to get a full dynamic frequency capable system by simply @@ -96,7 +95,6 @@ config CPU_FREQ_DEFAULT_GOV_ONDEMAND config CPU_FREQ_DEFAULT_GOV_CONSERVATIVE bool "conservative" select CPU_FREQ_GOV_CONSERVATIVE - select CPU_FREQ_GOV_PERFORMANCE help Use the CPUFreq governor 'conservative' as default. This allows you to get a full dynamic frequency capable system by simply @@ -107,7 +105,8 @@ config CPU_FREQ_DEFAULT_GOV_CONSERVATIVE endchoice config CPU_FREQ_GOV_PERFORMANCE - tristate "'performance' governor" + tristate + default y help This cpufreq governor sets the frequency statically to the highest available CPU frequency.