Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

["Jürgen E. Fischer" <fischer@linux-buechse.de>]

Hi Randy,

On Thu, Aug 02, 2007 at 12:09:26 -0700, Randy Dunlap wrote:
> > 6. One more second passes and 2nd abort comes in.
> > 7. Than a reset comes in. Here too Should driver check for hardware
> >    presence.
> > 
> > since ds.c is doing: p_dev->_removed=1;
> > before the shutdown. Maybe a solution is to have aha152x_stub.c,
> > which is the only one that knows of PCMCIA, Override queuecommand
> > and just check for p_dev->_removed==1. Something like:

> This makes sense, but it didn't work:

Looks like that's just because aha152x_bus_reset_host locks up when
debugging output is on.


--- a/aha152x.c	2007-08-02 21:27:12.756833348 +0200
+++ b/aha152x.c	2007-08-02 21:28:12.320227674 +0200
@@ -1102,7 +1102,7 @@
 
 #if defined(AHA152X_DEBUG)
 	if(HOSTDATA(shpnt)->debug & debug_eh) {
-		printk(DEBUG_LEAD "abort(%p)", CMDINFO(SCpnt), SCpnt);
+		printk(DEBUG_LEAD "abort(%p)\n", CMDINFO(SCpnt), SCpnt);
 		show_queues(shpnt);
 	}
 #endif
@@ -1267,15 +1267,15 @@
 {
 	unsigned long flags;
 
-	DO_LOCK(flags);
-
 #if defined(AHA152X_DEBUG)
 	if(HOSTDATA(shpnt)->debug & debug_eh) {
-		printk(KERN_DEBUG "scsi%d: bus reset", shpnt->host_no);
+		printk(KERN_DEBUG "scsi%d: bus reset\n", shpnt->host_no);
 		show_queues(shpnt);
 	}
 #endif
 
+	DO_LOCK(flags);
+
 	free_hard_reset_SCs(shpnt, &ISSUE_SC);
 	free_hard_reset_SCs(shpnt, &DISCONNECTED_SC);