From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: joachim.deguara@amd.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, michal.k.k.piotrowski@gmail.com,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [REGRESSION] tg3 dead after s2ram
Date: Fri, 03 Aug 2007 20:57:09 -0700 (PDT) [thread overview]
Message-ID: <20070803.205709.126573435.davem@davemloft.net> (raw)
In-Reply-To: <1186081829.18322.20.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 02 Aug 2007 12:10:29 -0700
> [TG3]: Fix suspend/resume problem.
>
> Joachim Deguara <joachim.deguara@amd.com> reported that tg3 devices
> would not resume properly if the device was shutdown before the system
> was suspended. In such scenario where the netif_running state is 0,
> tg3_suspend() would not save the PCI state and so the memory enable bit
> and bus master enable bit would be lost.
>
> We fix this by always saving and restoring the PCI state in
> tg3_suspend() and tg3_resume() regardless of netif_running() state.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Patch applied.
prev parent reply other threads:[~2007-08-04 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 9:28 [REGRESSION] tg3 dead after s2ram Joachim Deguara
2007-08-01 0:45 ` Andrew Morton
2007-08-01 7:53 ` Michael Chan
2007-08-01 8:01 ` Joachim Deguara
2007-08-01 17:47 ` Michael Chan
2007-08-01 21:00 ` Michael Chan
2007-08-02 8:05 ` Joachim Deguara
2007-08-02 9:15 ` Joachim Deguara
2007-08-02 9:23 ` David Miller
2007-08-02 19:10 ` Michael Chan
2007-08-02 22:06 ` David Miller
2007-08-02 23:38 ` Michael Chan
2007-08-03 9:47 ` Joachim Deguara
2007-08-03 9:47 ` Joachim Deguara
2007-08-04 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070803.205709.126573435.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=joachim.deguara@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.