From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Len Brown <lenb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
pm list <linux-pm@lists.linux-foundation.org>,
Adrian Bunk <bunk@stusta.de>
Subject: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
Date: Fri, 3 Aug 2007 23:59:36 +0200 [thread overview]
Message-ID: <200708032359.37677.rjw@sisk.pl> (raw)
From: Rafael J. Wysocki <rjw@sisk.pl>
Dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION introduced by commit
296699de6bdc717189a331ab6bbe90e05c94db06 "Introduce CONFIG_SUSPEND for
suspend-to-Ram and standby" are incorrect, as they don't cover the facts that
(1) not all architectures support suspend and (2) SMP hibernation is only
possible on X86 and PPC64 (if PPC64_SWSUSP is set).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
kernel/power/Kconfig | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: linux-2.6/kernel/power/Kconfig
===================================================================
--- linux-2.6.orig/kernel/power/Kconfig 2007-07-30 07:58:48.000000000 +0200
+++ linux-2.6/kernel/power/Kconfig 2007-08-03 23:29:57.000000000 +0200
@@ -74,7 +74,8 @@ config PM_TRACE
config SUSPEND_SMP_POSSIBLE
bool
- depends on (X86 && !X86_VOYAGER) || (PPC64 && (PPC_PSERIES || PPC_PMAC))
+ depends on (X86 && !X86_VOYAGER) \
+ || (PPC64 && (PPC_PSERIES || PPC_PMAC)) || ARM
depends on SMP
default y
@@ -92,7 +93,8 @@ config PM_SLEEP
config SUSPEND
bool "Suspend to RAM and standby"
depends on PM
- depends on !SMP || SUSPEND_SMP_POSSIBLE
+ depends on SUSPEND_SMP_POSSIBLE || ((BLACKFIN || MIPS || SUPERH || FRV \
+ || (PPC32 && PPC_MPC52xx)) && !SMP)
default y
---help---
Allow the system to enter sleep states in which main memory is
@@ -102,7 +104,8 @@ config SUSPEND
config HIBERNATION
bool "Hibernation (aka 'suspend to disk')"
depends on PM && SWAP
- depends on ((X86 || PPC64_SWSUSP || FRV || PPC32) && !SMP) || SUSPEND_SMP_POSSIBLE
+ depends on ((X86 || PPC64_SWSUSP || FRV || PPC32) && !SMP) \
+ || ((X86 || PPC64_SWSUSP) && SUSPEND_SMP_POSSIBLE)
---help---
Enable the suspend to disk (STD) functionality, which is usually
called "hibernation" in user interfaces. STD checkpoints the
next reply other threads:[~2007-08-03 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 21:59 Rafael J. Wysocki [this message]
2007-08-03 22:01 ` [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION Linus Torvalds
2007-08-03 22:47 ` Rafael J. Wysocki
2007-08-04 3:45 ` Len Brown
2007-08-04 3:45 ` Len Brown
2007-08-04 9:48 ` Rafael J. Wysocki
2007-08-04 22:09 ` Rafael J. Wysocki
2007-08-04 22:09 ` Rafael J. Wysocki
2007-08-04 9:48 ` Rafael J. Wysocki
2007-08-03 22:47 ` Rafael J. Wysocki
2007-08-03 22:01 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2007-08-03 21:59 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708032359.37677.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.