From: Robert Fitzsimons <robfitz@273k.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Steven Walter <stevenrwalter@gmail.com>,
git@vger.kernel.org, Robert Fitzsimons <robfitz@273k.net>,
Junio Hamano <gitster@pobox.com>
Subject: Re: [PATCH] gitweb: Fix handling of $file_name in feed generation
Date: Sat, 4 Aug 2007 01:27:08 +0100 [thread overview]
Message-ID: <20070804002708.GA9840@localhost> (raw)
In-Reply-To: <200708031950.43126.jnareb@gmail.com>
> Subject: [PATCH] gitweb: Fix handling of $file_name in feed generation
>
> The commit b6093a5c, by Robert Fitzsimons:
> "gitweb: Change atom, rss actions to use parse_commits."
> forgot to pass $file_name parameter to parse_commits subroutine.
>
> If git_feed is provided a file name, it ought to show only the history
> affecting that file or a directory. The title was being set
> correctly, but all commits from history were being shown.
>
> Signed-off-by: Steven Walter <stevenrwalter@gmail.com>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Silly me. Jakub's change is the correct fix for the bug.
Robert
prev parent reply other threads:[~2007-08-04 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 2:05 [PATCH] gitweb: Provide RSS feeds for file history Steven Walter
2007-08-03 9:10 ` Jakub Narebski
2007-08-03 17:50 ` [PATCH] gitweb: Fix handling of $file_name in feed generation Jakub Narebski
2007-08-04 0:25 ` Junio C Hamano
2007-08-04 0:27 ` Robert Fitzsimons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070804002708.GA9840@localhost \
--to=robfitz@273k.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=stevenrwalter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.