All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Bernd Schubert <bschubert@q-leap.de>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck/e2fsprogs: use sscanf() instead of atoi() in the option parser
Date: Fri, 3 Aug 2007 22:19:12 -0400	[thread overview]
Message-ID: <20070804021912.GG7449@thunk.org> (raw)
In-Reply-To: <f8q6is$tg3$1@sea.gmane.org>

On Wed, Aug 01, 2007 at 04:50:04PM +0200, Bernd Schubert wrote:
> [resent since the first mail doesn't seem to make it to this list]
> 
> using atoi() should be avoided in the option parser since it doesn't check
> for errors. I almost destroyed an important filesystem since I
> specified "e2fsck -C -n" and -n was parsed as option to -C

Hi Bernd,

Can you please include a DCO.  i.e.,

Signed-off-by: Bernd Schubert <bschubert@q-leap.de>

In your patch submissions.  See the SUBMITTING-PATCHES file in the
top-level directory of e2fsprogs source tree for the significance of
the Signed-off-by line.  For this patch, can you indicate whether you
are willing to add a Signed-off-by: DCO?

Thanks, regards,

						- Ted

  reply	other threads:[~2007-08-04  6:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 14:50 [PATCH] e2fsck/e2fsprogs: use sscanf() instead of atoi() in the option parser Bernd Schubert
2007-08-04  2:19 ` Theodore Tso [this message]
2007-08-06 10:53   ` Bernd Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070804021912.GG7449@thunk.org \
    --to=tytso@mit.edu \
    --cc=bschubert@q-leap.de \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.