All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Beauchemin, Mark" <Mark.Beauchemin@sycamorenet.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH -rt] Preemption problem in kernel RT Patch
Date: Mon, 6 Aug 2007 09:13:45 +0200	[thread overview]
Message-ID: <20070806071345.GD5359@elte.hu> (raw)
In-Reply-To: <77B279EC7347F341A6AE891AA6AD68E93142D2@ranchero.sycamorenet.com>


* Beauchemin, Mark <Mark.Beauchemin@sycamorenet.com> wrote:

> sorry..  I sent the wrong patch file.  There was a warning in the 
> other one.

> -       int                     xmit_lock_owner;
> +#ifdef CONFIG_PREEMPT_RT
> +       void *                  xmit_lock_owner;
> +#else
> +       int                     xmit_lock_owner;
> +#endif

could you please change this to use 'current' (instead of the CPU 
number) as the xmit_lock_owner unconditionally? That results in much 
fewer #ifdefs and far cleaner code.

	Ingo

  reply	other threads:[~2007-08-06  7:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21 19:39 [PATCH -rt] Preemption problem in kernel RT Patch Beauchemin, Mark
2007-06-22  8:03 ` Thomas Gleixner
2007-06-23 14:08   ` Beauchemin, Mark
2007-06-23 14:26     ` Thomas Gleixner
2007-07-24 15:48       ` Beauchemin, Mark
2007-07-24 19:15         ` Ingo Molnar
2007-07-24 19:36           ` Beauchemin, Mark
2007-08-01 14:15           ` Beauchemin, Mark
2007-08-01 14:22             ` Beauchemin, Mark
2007-08-06  7:13               ` Ingo Molnar [this message]
2007-08-07 19:41                 ` Beauchemin, Mark
2007-09-17 13:03                   ` Beauchemin, Mark
2007-09-17 13:59                     ` Ingo Molnar
2009-10-14 12:55 ` dtslinux
2009-10-14 15:38   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070806071345.GD5359@elte.hu \
    --to=mingo@elte.hu \
    --cc=Mark.Beauchemin@sycamorenet.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.