From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Johannes Berg <johannes@sipsolutions.net>, Pavel Machek <pavel@ucw.cz>
Cc: Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@stusta.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Russell King <rmk@arm.linux.org.uk>, Len Brown <lenb@kernel.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [linux-pm] Re: [Resend][PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION (updated)
Date: Mon, 6 Aug 2007 13:14:41 +0200 [thread overview]
Message-ID: <200708061314.42632.rjw@sisk.pl> (raw)
In-Reply-To: <1186392591.28655.35.camel@johannes.berg>
On Monday, 6 August 2007 11:29, Johannes Berg wrote:
> On Mon, 2007-08-06 at 11:07 +0200, Pavel Machek wrote:
> > Hi!
> >
> > > +config SUSPEND_UP_POSSIBLE
> > > + bool
> > > + depends on (X86 && !X86_VOYAGER) || (PPC32 && PPC_MPC52xx) \
> > > + || (PPC64 && (PPC_PSERIES || PPC_PMAC)) || ARM || BLACKFIN \
> > > + || MIPS || SUPERH || FRV
> > > + depends on !SMP
> > > + default y
> >
> > I guess I'd rather left SUSPEND_UP_POSSIBLE to allways y (as it always
> > was), and let architectures that can't handle it not return "mem"
> > from list of valid states...
>
> Yeah, that's the utterly broken interface we used to have. Until I fixed
> it to have no valid states until architectures implement suspend_ops.
> Still, I disagree, why bother with compiling code that can't ever be
> used?
Yes, that's the idea.
BTW, Pavel please see: http://lkml.org/lkml/2007/8/3/303
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-08-06 11:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 17:06 [Resend][PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION (updated) Rafael J. Wysocki
2007-08-06 9:07 ` Pavel Machek
2007-08-06 9:29 ` [linux-pm] " Johannes Berg
2007-08-06 10:26 ` Pavel Machek
2007-08-06 10:26 ` [linux-pm] " Pavel Machek
2007-08-06 11:15 ` Johannes Berg
2007-08-06 11:22 ` Johannes Berg
2007-08-06 11:22 ` Johannes Berg
2007-08-06 11:36 ` Pavel Machek
2007-08-06 11:36 ` [linux-pm] " Pavel Machek
2007-08-06 11:56 ` Rafael J. Wysocki
2007-08-07 9:42 ` Johannes Berg
2007-08-07 9:42 ` Johannes Berg
2007-08-06 11:56 ` Rafael J. Wysocki
2007-08-06 11:15 ` Johannes Berg
2007-08-06 11:14 ` Rafael J. Wysocki
2007-08-06 11:14 ` Rafael J. Wysocki [this message]
2007-08-06 9:29 ` Johannes Berg
2007-08-06 9:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708061314.42632.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=paulus@samba.org \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.