All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Swetland <swetland@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Simon Hausmann <simon@lst.de>,
	git@vger.kernel.org, Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH] git-p4: Fix support for symlinks.
Date: Tue, 7 Aug 2007 02:10:49 -0700	[thread overview]
Message-ID: <20070807091049.GA13308@bulgaria> (raw)
In-Reply-To: <7vtzrb68kq.fsf@assigned-by-dhcp.cox.net>

[Junio C Hamano <gitster@pobox.com>]
> Simon Hausmann <simon@lst.de> writes:
> 
> [ patch for correct symlink handling ]
> 
> Thanks for a quick fix.
> 
> Brian, does this resolve the issue for you?  I do not have an
> access to p4 myself so I won't make a good judge in this area
> myself.  An Ack is appreciated.

Ack.

Looks good here.  I can now sync from the p4 tree into git, check out
from git and do a clean build, and everything's happy.

Thanks for the quick fix, Simon!

One observation on git-p4 -- it's a little memory hungry when processing
large syncs.  I haven't tried incremental syncs on top of the initial
one though -- if it's only the initial that's expensive it's not that
big a deal.

It seemed to top out around 988MB resident.  The branch I was importing
is about 562MB when checked out and the resulting git repository is
about 175MB.

Brian

  reply	other threads:[~2007-08-07  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07  8:25 [PATCH] git-p4: Fix support for symlinks Simon Hausmann
2007-08-07  8:40 ` Junio C Hamano
2007-08-07  9:10   ` Brian Swetland [this message]
2007-08-08  1:36     ` Scott Lamb
  -- strict thread matches above, loose matches on Subject: below --
2007-08-07 10:28 Simon Hausmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070807091049.GA13308@bulgaria \
    --to=swetland@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hanwen@google.com \
    --cc=simon@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.