All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	anton@samba.org, wli@holomorphy.com, linux-mm@kvack.org
Subject: Re: [RFC][PATCH 1/2][UPDATED] hugetlb: search harder for memory in alloc_fresh_huge_page()
Date: Tue, 7 Aug 2007 18:32:56 -0700	[thread overview]
Message-ID: <20070808013256.GE15714@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0708071714060.5001@schroedinger.engr.sgi.com>

On 07.08.2007 [17:14:31 -0700], Christoph Lameter wrote:
> On Tue, 7 Aug 2007, Nishanth Aravamudan wrote:
> 
> > Which change? Using nid without a VM_BUG_ON (as in the original patch)
> > or adding a VM_BUG_ON and using page_to_nid()?
> 
> Adding VM_BUG_ON. If page_alloc does not work then something basic is 
> broken.

I agree. So perhaps there needs to be a VM_BUG_ON_ONCE() or something
somewhere in the core code for the case of a __GFP_THISNODE allocation
going off node?

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-08-08  1:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07 17:14 [RFC][PATCH 1/2] hugetlb: search harder for memory in alloc_fresh_huge_page() Nishanth Aravamudan
2007-08-07 17:15 ` [RFC][PATCH 2/2][V10] hugetlb: fix pool allocation with memoryless nodes Nishanth Aravamudan
2007-08-07 20:15 ` [RFC][PATCH 1/2] hugetlb: search harder for memory in alloc_fresh_huge_page() Lee Schermerhorn
2007-08-07 22:12   ` [RFC][PATCH 1/2][UPDATED] " Nishanth Aravamudan
2007-08-07 22:54     ` Christoph Lameter
2007-08-07 23:02       ` Nishanth Aravamudan
2007-08-08  0:14         ` Christoph Lameter
2007-08-08  1:32           ` Nishanth Aravamudan [this message]
2007-08-08 13:20             ` Lee Schermerhorn
2007-08-08 13:17       ` Lee Schermerhorn
2007-08-07 23:34     ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070808013256.GE15714@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=anton@samba.org \
    --cc=clameter@sgi.com \
    --cc=linux-mm@kvack.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.