From: Frederik Deweerdt <deweerdt@free.fr>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Laurent Pinchart <laurentp@cse-semaphore.com>,
paulkf@microgate.com, linux-kernel@vger.kernel.org
Subject: Re: Serial buffer memory leak
Date: Wed, 8 Aug 2007 16:26:28 +0200 [thread overview]
Message-ID: <20070808142628.GA14494@slug> (raw)
In-Reply-To: <20070808144532.5e3a1998@the-village.bc.nu>
On Wed, Aug 08, 2007 at 02:45:32PM +0100, Alan Cox wrote:
> > I'm not familiar enough with the tty code to decide what the proper fix should
> > be. I'll try to write a patch if someone could point me in the right
> > direction.
>
> Something like this perhaps ?
>
[....]
> - * flush all the buffers containing receive data
> + * flush all the buffers containing receive data. Caller must
> + * hold the buffer lock and must have ensured no parallel flush to
> + * ldisc is running.
> *
> * Locking: none
^^^^
> */
Isn't the comment a bit misleading here? The caller must hold tty->buf.lock.
Frederik
next prev parent reply other threads:[~2007-08-08 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 9:58 Serial buffer memory leak Laurent Pinchart
2007-08-08 13:45 ` Alan Cox
2007-08-08 14:11 ` Paul Fulghum
2007-08-08 14:28 ` Laurent Pinchart
2007-08-08 14:52 ` Paul Fulghum
2007-08-08 15:16 ` Alan Cox
2007-08-08 15:32 ` Alan Cox
2007-08-08 17:35 ` Paul Fulghum
2007-08-08 14:26 ` Frederik Deweerdt [this message]
2007-08-08 14:13 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808142628.GA14494@slug \
--to=deweerdt@free.fr \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=laurentp@cse-semaphore.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.