Re: [patch 02/14] Memoryless nodes: introduce mask of nodes with memory

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 08.08.2007 [12:55:14 -0700], Nishanth Aravamudan wrote:
> On 08.08.2007 [12:38:04 -0700], Andrew Morton wrote:
> > On Fri, 03 Aug 2007 20:01:02 -0700
> > Christoph Lameter <clameter@sgi.com> wrote:
> > 
> > > +/* Any regular memory on that node ? */
> > > +static void check_for_regular_memory(pg_data_t *pgdat)
> > > +{
> > > +#ifdef CONFIG_HIGHMEM
> > > +	enum zone_type zone;
> > > +
> > > +	for (zone = 0; zone <= ZONE_NORMAL; zone++)
> > > +		if (pgdat->node_zones[zone].present_pages)
> > > +			node_set_state(nid, N_NORMAL_MEMORY);
> > > +	}
> > > +#endif
> > > +}
> > 
> > mm/page_alloc.c: In function 'check_for_regular_memory':
> > mm/page_alloc.c:2427: error: 'nid' undeclared (first use in this function)
> > mm/page_alloc.c:2427: error: (Each undeclared identifier is reported only once
> > mm/page_alloc.c:2427: error: for each function it appears in.)
> > mm/page_alloc.c: At top level:
> > mm/page_alloc.c:2430: error: expected identifier or '(' before '}' token
> > 
> > OK, easily fixable with
> > 
> > /* Any regular memory on that node ? */
> > static void check_for_regular_memory(pg_data_t *pgdat)
> > {
> > #ifdef CONFIG_HIGHMEM
> > 	enum zone_type zone_type;
> > 	
> > 	for (zone_type = 0; zone_type <= ZONE_NORMAL; zone_type++) {
> > 		struct zone *zone = &pgdat->node_zones[zone_type];
> > 		if (zone->present_pages)
> > 			node_set_state(zone_to_nid(zone), N_NORMAL_MEMORY);
> > 	}
> > #endif
> > }
> > 
> > but we continue to have some significant testing issues out there.		
> 
> This would be because the patch that Christoph submitted here is not the
> same as the patch that Mel and I tested...There was no
> check_for_regular_memory() function in the kernels I was building.

To try and remedy this -- I'll regrab this stack and rebase my patches
again. Test everything and resubmit mine.

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>