All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 1/2] [POWERPC] MPC832x_RDB: update dts to use spi, register mmc_spi stub
Date: Thu, 9 Aug 2007 13:07:52 +1000	[thread overview]
Message-ID: <20070809030752.GB8261@localhost.localdomain> (raw)
In-Reply-To: <20070808170921.GA21487@localhost.localdomain>

On Wed, Aug 08, 2007 at 09:09:21PM +0400, Anton Vorontsov wrote:
> mmc_spi already tested to work. When it will hit mainline
> the only change that will be needed is replacing "spidev"
> by "mmc_spi".
> 
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>  arch/powerpc/boot/dts/mpc832x_rdb.dts     |    4 ++-
>  arch/powerpc/platforms/83xx/mpc832x_rdb.c |   52 +++++++++++++++++++++++++++++
>  2 files changed, 55 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc832x_rdb.dts b/arch/powerpc/boot/dts/mpc832x_rdb.dts
> index e9c332f..664dd16 100644
> --- a/arch/powerpc/boot/dts/mpc832x_rdb.dts
> +++ b/arch/powerpc/boot/dts/mpc832x_rdb.dts
> @@ -207,15 +207,17 @@
>  
>  		spi@4c0 {
>  			device_type = "spi";
> +			fsl,device-id = <1>;

Hrm... Freescale is using these 'fsl,device-id' properties, I'm
guessing they're basically the same thing as the 'cell-index' used in
the EMAC binding.

We should co-ordinate better on this, if it's to become a
convention...

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2007-08-09  3:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-08 17:07 [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb Anton Vorontsov
2007-08-08 17:09 ` [PATCH v3 1/2] [POWERPC] MPC832x_RDB: update dts to use spi, register mmc_spi stub Anton Vorontsov
2007-08-09  3:07   ` David Gibson [this message]
2007-08-09 20:15     ` Segher Boessenkool
2007-08-10  1:02       ` David Gibson
2007-08-10 20:42         ` Segher Boessenkool
2007-08-12  8:16           ` David Gibson
2007-08-12 11:36             ` Segher Boessenkool
2007-08-08 17:09 ` [PATCH v3 2/2] [POWERPC] fsl_soc: add support for fsl_spi Anton Vorontsov
2007-08-09  5:33   ` Kumar Gala
2007-08-09  5:34 ` [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb Kumar Gala
2007-08-09 20:21 ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070809030752.GB8261@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=avorontsov@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.