From: Ralf Baechle <ralf@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
Jeff Garzik <jeff@garzik.org>,
Russell King <rmk@arm.linux.org.uk>,
Lennert Buytenhek <kernel@wantstofly.org>,
Bryan Wu <bryan.wu@analog.com>, "H.PeterAnvin" <hpa@zytor.com>,
Greg Ungerer <gerg@uclinux.org>,
Kumar Gala <galak@kernel.crashing.org>,
Grant Grundler <grundler@parisc-linux.org>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] Add missing KERN_<level> to multiline printk(KERN_<level>...)
Date: Thu, 9 Aug 2007 13:32:41 +0100 [thread overview]
Message-ID: <20070809123241.GA12818@linux-mips.org> (raw)
In-Reply-To: <1186619327.3073.57.camel@localhost>
On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote:
> Some uses of printk are missing KERN_<level> on the second
> and subsequent lines.
>
> For instance:
>
> printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2);
>
> Line1 is marked log_level: info
> Line2 is marked log_level: unknown
>
> Some lines have trailing spaces after \n, removed where appropriate.
>
> Signed-off-by: Joe Perches <joe@perches.com>
For the MIPS bits.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
But not without the note that mentioned printk should be deleted because
this is not Windows 95.
Ralf
next prev parent reply other threads:[~2007-08-09 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 0:28 [PATCH] Add missing KERN_<level> to multiline printk(KERN_<level>...) Joe Perches
2007-08-09 6:25 ` Grant Grundler
2007-08-09 12:32 ` Ralf Baechle [this message]
2007-08-09 21:24 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809123241.GA12818@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=bryan.wu@analog.com \
--cc=clameter@sgi.com \
--cc=galak@kernel.crashing.org \
--cc=gerg@uclinux.org \
--cc=gregkh@suse.de \
--cc=grundler@parisc-linux.org \
--cc=hpa@zytor.com \
--cc=jeff@garzik.org \
--cc=joe@perches.com \
--cc=kernel@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.