From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lazybastard.de ([212.112.238.170] helo=longford.lazybastard.org) by canuck.infradead.org with esmtp (Exim 4.63 #1 (Red Hat Linux)) id 1IJFPm-0004Ck-Ma for linux-mtd@lists.infradead.org; Thu, 09 Aug 2007 17:19:33 -0400 Date: Thu, 9 Aug 2007 22:03:16 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: Arnd Bergmann Subject: Re: [Patch 02/18] include/linux/logfs.h Message-ID: <20070809200315.GC9036@lazybastard.org> References: <20070808161234.GB15319@lazybastard.org> <20070808161428.GD15319@lazybastard.org> <200708090056.30350.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200708090056.30350.arnd@arndb.de> Cc: akpm@osdl.org, =?utf-8?B?SsO2cm4=?= Engel , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, Thomas Gleixner , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 9 August 2007 00:56:29 +0200, Arnd Bergmann wrote: > On Wednesday 08 August 2007, Jörn Engel wrote: > > +++ linux-2.6.21logfs/include/linux/logfs.h     2007-08-08 02:57:37.000000000 +0200 > > @@ -0,0 +1,500 @@ > > +/* > > + * fs/logfs/logfs.h > > + * > > The comment does not match the file name. Better remove the file names > entirely from introduction comments. Maybe. This file needs to get moved again anyway. Jörn -- Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762996AbXHIUHa (ORCPT ); Thu, 9 Aug 2007 16:07:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752655AbXHIUHS (ORCPT ); Thu, 9 Aug 2007 16:07:18 -0400 Received: from lazybastard.de ([212.112.238.170]:59376 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbXHIUHP (ORCPT ); Thu, 9 Aug 2007 16:07:15 -0400 Date: Thu, 9 Aug 2007 22:03:16 +0200 From: =?utf-8?B?SsO2cm4=?= Engel To: Arnd Bergmann Cc: =?utf-8?B?SsO2cm4=?= Engel , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, David Woodhouse , Thomas Gleixner Subject: Re: [Patch 02/18] include/linux/logfs.h Message-ID: <20070809200315.GC9036@lazybastard.org> References: <20070808161234.GB15319@lazybastard.org> <20070808161428.GD15319@lazybastard.org> <200708090056.30350.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200708090056.30350.arnd@arndb.de> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 August 2007 00:56:29 +0200, Arnd Bergmann wrote: > On Wednesday 08 August 2007, Jörn Engel wrote: > > +++ linux-2.6.21logfs/include/linux/logfs.h     2007-08-08 02:57:37.000000000 +0200 > > @@ -0,0 +1,500 @@ > > +/* > > + * fs/logfs/logfs.h > > + * > > The comment does not match the file name. Better remove the file names > entirely from introduction comments. Maybe. This file needs to get moved again anyway. Jörn -- Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?SsO2cm4=?= Engel Subject: Re: [Patch 02/18] include/linux/logfs.h Date: Thu, 9 Aug 2007 22:03:16 +0200 Message-ID: <20070809200315.GC9036@lazybastard.org> References: <20070808161234.GB15319@lazybastard.org> <20070808161428.GD15319@lazybastard.org> <200708090056.30350.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?utf-8?B?SsO2cm4=?= Engel , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, akpm@osdl.org, David Woodhouse , Thomas Gleixner To: Arnd Bergmann Return-path: Received: from lazybastard.de ([212.112.238.170]:59376 "EHLO longford.lazybastard.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbXHIUHP (ORCPT ); Thu, 9 Aug 2007 16:07:15 -0400 Content-Disposition: inline In-Reply-To: <200708090056.30350.arnd@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 9 August 2007 00:56:29 +0200, Arnd Bergmann wrote: > On Wednesday 08 August 2007, J=C3=B6rn Engel wrote: > > +++ linux-2.6.21logfs/include/linux/logfs.h=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A02007-08-08 02:57:37.000000000 +0200 > > @@ -0,0 +1,500 @@ > > +/* > > + * fs/logfs/logfs.h > > + * >=20 > The comment does not match the file name. Better remove the file name= s > entirely from introduction comments. Maybe. This file needs to get moved again anyway. J=C3=B6rn --=20 Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html