Re: [PATCH] To Cleanup TWL-Core driver

[Tony Lindgren <tony@atomide.com>]

* Nishanth Menon <menon.nishanth@gmail.com> [070726 04:21]:
> Syed Mohammed, Khasim stated on 7/25/2007 7:19 PM:
> > diff -purN linux-omap/include/asm-arm/arch-omap/twl4030.h lin_for_mmc/include/asm-arm/arch-omap/twl4030.h
> >  
> > +/*
> > + * Exported TWL4030 GPIO APIs
> > + */
> > +int twl4030_get_gpio_datain(int gpio);
> > +int twl4030_request_gpio(int gpio);
> > +int twl4030_set_gpio_edge_ctrl(int gpio, int edge);
> > +int twl4030_set_gpio_debounce(int gpio, int enable);
> > +int twl4030_free_gpio(int gpio);
> > +
> >  #endif /* End of __TWL4030_H */
> > _______________________________________________
> >   
> I think twl4030.h is a shared header & twlgpio driver is independent of
> twl core driver. if i disable this, there wont be even a warning for the
> file using this apis. why dont we cover them with the CONFIG macro for
> twl gpio? - Am not sure if that is acceptable as per coding standards OR
> if we need to create another shared header??...

Do you have a patch to combine the headers?

Pushing Khasim's patch today.

Tony