From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Andi Kleen <andi@firstfloor.org>,
prasanna@in.ibm.com, ananth@in.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net
Subject: [patch 8/9] Text Edit Lock - kprobes i386
Date: Sun, 12 Aug 2007 11:04:10 -0400 [thread overview]
Message-ID: <20070812150641.294372391@polymtl.ca> (raw)
In-Reply-To: 20070812150402.148764478@polymtl.ca
[-- Attachment #1: text-edit-lock-kprobes-i386.patch --]
[-- Type: text/plain, Size: 1542 bytes --]
Kprobes can use the text edit lock to insure mutual exclusion when editing the
code.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Andi Kleen <andi@firstfloor.org>
CC: prasanna@in.ibm.com
CC: ananth@in.ibm.com
CC: anil.s.keshavamurthy@intel.com
CC: davem@davemloft.net
---
arch/i386/kernel/kprobes.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Index: linux-2.6-lttng/arch/i386/kernel/kprobes.c
===================================================================
--- linux-2.6-lttng.orig/arch/i386/kernel/kprobes.c 2007-08-10 13:47:25.000000000 -0400
+++ linux-2.6-lttng/arch/i386/kernel/kprobes.c 2007-08-10 13:49:21.000000000 -0400
@@ -170,12 +170,16 @@ int __kprobes arch_prepare_kprobe(struct
void __kprobes arch_arm_kprobe(struct kprobe *p)
{
- text_poke(p->addr, ((unsigned char []){BREAKPOINT_INSTRUCTION}), 1);
+ kernel_text_mark_rw((unsigned long) p->addr, sizeof(kprobe_opcode_t));
+ *p->addr = BREAKPOINT_INSTRUCTION;
+ kernel_text_unmark((unsigned long) p->addr, sizeof(kprobe_opcode_t));
}
void __kprobes arch_disarm_kprobe(struct kprobe *p)
{
- text_poke(p->addr, &p->opcode, 1);
+ kernel_text_mark_rw((unsigned long) p->addr, sizeof(kprobe_opcode_t));
+ *p->addr = p->opcode;
+ kernel_text_unmark((unsigned long) p->addr, sizeof(kprobe_opcode_t));
}
void __kprobes arch_remove_kprobe(struct kprobe *p)
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-08-12 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 15:04 [patch 0/9] Text Edit Lock Mathieu Desnoyers
2007-08-12 15:04 ` [patch 1/9] Kprobes - use a mutex to protect the instruction pages list Mathieu Desnoyers
2007-08-12 15:04 ` [patch 2/9] Kprobes - do not use kprobes mutex in arch code Mathieu Desnoyers
2007-08-12 15:04 ` [patch 3/9] Kprobes - declare kprobe_mutex static Mathieu Desnoyers
2007-08-12 15:04 ` [patch 4/9] Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2007-08-12 15:04 ` [patch 5/9] Text Edit Lock - i386 Mathieu Desnoyers
2007-08-12 15:04 ` [patch 6/9] Text Edit Lock - x86_64 Mathieu Desnoyers
2007-08-12 15:04 ` [patch 7/9] Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2007-08-12 15:04 ` Mathieu Desnoyers [this message]
2007-08-12 15:04 ` [patch 9/9] Text Edit Lock - kprobes x86_64 Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070812150641.294372391@polymtl.ca \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.