From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([66.187.233.31]:54630 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753801AbXHMLka (ORCPT ); Mon, 13 Aug 2007 07:40:30 -0400 Date: Mon, 13 Aug 2007 07:40:20 -0400 From: Chris Snook Subject: [PATCH 19/23] make atomic_read() and atomic_set() behavior consistent on sparc64 Message-ID: <20070813114020.GS24018@shell.boston.redhat.com> References: <46C03885.7000109@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C03885.7000109@redhat.com> Sender: linux-arch-owner@vger.kernel.org To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Cc: akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com, Segher Boessenkool , "Luck, Tony" , Chris Friesen , "Robert P. J. Day" List-ID: From: Chris Snook Use volatile consistently in atomic.h on sparc64. Signed-off-by: Chris Snook --- linux-2.6.23-rc3-orig/include/asm-sparc64/atomic.h 2007-07-08 19:32:17.000000000 -0400 +++ linux-2.6.23-rc3/include/asm-sparc64/atomic.h 2007-08-13 06:17:01.000000000 -0400 @@ -11,17 +11,31 @@ #include #include -typedef struct { volatile int counter; } atomic_t; -typedef struct { volatile __s64 counter; } atomic64_t; +typedef struct { int counter; } atomic_t; +typedef struct { __s64 counter; } atomic64_t; #define ATOMIC_INIT(i) { (i) } #define ATOMIC64_INIT(i) { (i) } -#define atomic_read(v) ((v)->counter) -#define atomic64_read(v) ((v)->counter) +static __inline__ int atomic_read(atomic_t *v) +{ + return *(volatile int *)&v->counter; +} + +static __inline__ __s64 atomic64_read(atomic64_t *v) +{ + return *(volatile __s64 *)&v->counter; +} -#define atomic_set(v, i) (((v)->counter) = i) -#define atomic64_set(v, i) (((v)->counter) = i) +static __inline__ void atomic_set(atomic_t *v, int i) +{ + *(volatile int *)&v->counter = i; +} + +static __inline__ void atomic64_set(atomic64_t *v, __s64 i) +{ + *(volatile __s64 *)&v->counter = i; +} extern void atomic_add(int, atomic_t *); extern void atomic64_add(int, atomic64_t *);