All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jan Beulich <jbeulich@novell.com>
Cc: Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, patches@x86-64.org
Subject: Re: [PATCH] x86: optionally show last exception from/to register contents
Date: Mon, 13 Aug 2007 16:21:10 +0200	[thread overview]
Message-ID: <20070813142110.GC3406@bingen.suse.de> (raw)
In-Reply-To: <46C0751E.76E4.0078.0@novell.com>

> I though you did, but since I never saw it appear in any release, I posted
> this one...

It's a little different (and somewhat hackish I admit) 
ftp://firstfloor.org/pub/ak/x86_64/debug/last-branch
It has far more overhead than yours of course.

The only way to merge something like that would be dynamic
patching and I was never quite motivated for that.

> So especially with the first concern of yours - is it worth at all rev-ing this
> patch to address the other change requests you voiced?

The patch is useful even with the race, just document somewhere
that it is unreliable (perhaps in the printk itself) and do the
other changes.

I would also suggest to enable it by default.

-Andi

  reply	other threads:[~2007-08-13 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 11:33 [PATCH] x86: optionally show last exception from/to register contents Jan Beulich
2007-08-13 13:08 ` Andi Kleen
2007-08-13 13:13   ` Jan Beulich
2007-08-13 14:21     ` Andi Kleen [this message]
2007-08-13 16:45       ` Randy Dunlap
2007-08-13 15:05   ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070813142110.GC3406@bingen.suse.de \
    --to=ak@suse.de \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.