All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: ACPI battery cleanup.
Date: Wed, 15 Aug 2007 00:44:29 -0400	[thread overview]
Message-ID: <200708150044.29820.lenb@kernel.org> (raw)
In-Reply-To: <46BDBAEF.5030204@suse.de>

On Saturday 11 August 2007 09:34, Alexey Starikovskiy wrote:
> Hi Len,
> 
> Here are patches to clean up ACPI battery driver. Please review and add
> to -mm series.

whelp, i got this to apply -- only problem was it added some whitespace errors.
and it built.

However, I would prefer....
More detailed check-in comments (or _any_ check-in comments for that matter)
saying what changed and why.

Series of smaller patches instead of 300-line single patches

series sent as an e-mail series, not an mbox attachment.
nobody reads mbox attachments.

I don't think these are getting the eyeballs on them that they need
because of these issues.

thanks,
-len

  reply	other threads:[~2007-08-15  4:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-11 13:34 ACPI battery cleanup Alexey Starikovskiy
2007-08-15  4:44 ` Len Brown [this message]
2007-08-15  9:19   ` Packard Bell DSDT issue raphaello-mouse
2007-08-17 10:27     ` raphaello-mouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708150044.29820.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=astarikovskiy@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.