From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Levon Subject: Re: [PATCH] Fix 64-bit foreign header check Date: Wed, 15 Aug 2007 16:27:05 +0100 Message-ID: <20070815152705.GA9299@barman.uk.sun.com> References: <20070815143716.GA8459@barman.uk.sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Aug 15, 2007 at 03:59:49PM +0100, Keir Fraser wrote: > >> Won't gcc produce 64-bit binaries by default in a 64-bit environment? > > > > There is no such thing as a "64-bit environment" on Solaris, all machines ship > > with both 32 and 64 bit functionality (of course the kernel must be 64-bit to > > actually /use/ such). > > > > Thus we build twice, once in 32-bit, once in 64-bit. > > Then isn't your TARGET_ARCH!=COMPILE_ARCH for one of these builds? Sounds > like you have a 32-bit-ish compile environment (since you produce 32-bit > binaries by default), and hence it would be correct to have > COMPILE_ARCH==x86_32 for both builds. There is no such "32-bit" environment, we can always produce both. What you're suggesting sounds like a cross-compile. This is absolutely not a cross compile; in particular we can and do want this header check to happen. We set XEN_COMPILE_ARCH by hand to 64-bit since the Xen makefiles have the notion that uname has anything to do with 32 or 64 bitness (a Linux-ism; in fact an x86_64-Linux-ism, since I believe other Linux arches do it the traditional way). regards john