From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: debug printk's
Date: Thu, 16 Aug 2007 11:24:02 +0000 [thread overview]
Message-ID: <20070816112402.GI16277@parisc-linux.org> (raw)
In-Reply-To: <20070816070719.550CB179C7E@place.org>
On Thu, Aug 16, 2007 at 02:07:19AM -0500, Paul Jimenez wrote:
> So: 187 definitions of dprintk and 130 definitions of DPRINTK. Plus
> 10 mixed-case fans and various and sundry miscellaneous versions. Note
> this is not *uses*, it's the number of *definitions*.
>
> So, to clarify my original question a bit: is there policy we can refer
> to to justify cleaning this up?
pr_debug() in include/linux/kernel.h, which also refers to dev_dbg(),
neither of which you mentioned ;-)
But take it slowly, co-ordinate with the driver author, and don't try to
tell people that it's policy -- it's a best practice, sure, but people
are free to ignore it if it makes their life easier.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2007-08-16 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 7:07 debug printk's Paul Jimenez
2007-08-16 11:24 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816112402.GI16277@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.