From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: PATCH: 0/10: Merge xenfb & xenconsoled into qemu-dm Date: Thu, 16 Aug 2007 13:49:39 +0100 Message-ID: <20070816124939.GA16779@redhat.com> References: <20070815200056.GE22579@redhat.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, Aug 16, 2007 at 08:30:08AM +0100, Keir Fraser wrote: > On 15/8/07 21:00, "Daniel P. Berrange" wrote: > > > The only feature this re-factoring looses is the ability to have the paravirt > > text console persistently logged to a file. QEMU allows us to specify that > > a character device is either sent to a PTY, or a file, but not both at the > > same time. I'm thinking about ways in which QEMU's character device config > > syntax & drivers may be extended to allow use of a PTY & File concurrently. > > > > The patches should be applied in order - after each individual patch you > > should still have a fully operational system for both FV & PV. > > Have you tested both HVM and PV guests with save/restore, migration, and > *failed* save/restore (e.g., by forcing an error in xc_domain_save.c)? The > last needs care because qemu-dm must be kept around until the last moment, > in case the save or migration fails. I've not tested failed save/restore or migration - just normal save/restore for FV & PV. I'll do some further testing of the scenarios you suggest. I don't think I should have broken anything in qemu-dm for HVM because in the HVM codepaths I merely moved code from one file to another. > Are these patches intended to be applied now, or are they RFC? They could be applied now, but was expecting people might have some feedback /recommendations for changes - Christian normally has lots of good comments for QEMU related stuff. So if I have to do another revision of the patches I'm fine with it. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|