From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IM2Hv-0004kW-Iz for user-mode-linux-devel@lists.sourceforge.net; Fri, 17 Aug 2007 06:54:55 -0700 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IM2Hu-00008b-4o for user-mode-linux-devel@lists.sourceforge.net; Fri, 17 Aug 2007 06:54:55 -0700 Date: Fri, 17 Aug 2007 09:54:46 -0400 From: Jeff Dike Message-ID: <20070817135446.GA5725@c2.user-mode-linux.org> References: <20070815235825.GB17004@redhat.com> <1187224811.5906.55.camel@localhost> <20070816145210.GD6670@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [uml-devel] [PATCH] hostfs: Remove pointless if statement List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Satyam Sharma Cc: Joe Perches , Linux Kernel , user-mode-linux-devel@lists.sourceforge.net On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote: > We normally use "comments" for that, not dead code that a compiler > then elids ;-) I'd argue that comments are for when you can't make the code self-explanatory. > [PATCH] hostfs: Remove pointless if statement > > And replace with comment saying we don't handle ctime. > Also some codingstyle while I was there. I'll forward this upstream. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763AbXHQNzl (ORCPT ); Fri, 17 Aug 2007 09:55:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752535AbXHQNzc (ORCPT ); Fri, 17 Aug 2007 09:55:32 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:55476 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbXHQNzb (ORCPT ); Fri, 17 Aug 2007 09:55:31 -0400 Date: Fri, 17 Aug 2007 09:54:46 -0400 From: Jeff Dike To: Satyam Sharma Cc: Joe Perches , Linux Kernel , user-mode-linux-devel@lists.sourceforge.net Subject: Re: [PATCH] hostfs: Remove pointless if statement Message-ID: <20070817135446.GA5725@c2.user-mode-linux.org> References: <20070815235825.GB17004@redhat.com> <1187224811.5906.55.camel@localhost> <20070816145210.GD6670@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 17, 2007 at 12:24:23PM +0530, Satyam Sharma wrote: > We normally use "comments" for that, not dead code that a compiler > then elids ;-) I'd argue that comments are for when you can't make the code self-explanatory. > [PATCH] hostfs: Remove pointless if statement > > And replace with comment saying we don't handle ctime. > Also some codingstyle while I was there. I'll forward this upstream. Jeff -- Work email - jdike at linux dot intel dot com