Re: [PATCH] 64 bit ino support for NFS server

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Aug 17, 2007 at 02:30:31PM -0400, Peter Staubach wrote:
> J. Bruce Fields wrote:
>> 	- This would be better as two, maybe three separate patches;
>> 	  e.g.  moving the lease_get_mtime out of encode_fattr3 could be
>> 	  done separately first.  Ideally we'd do some trivial
>> 	  transformations like that, followed by one change that
>> 	  actually changes the inode behavior.  That makes the whole
>> 	  thing trival to review.
>
> My test system isn't at a place where I could factor the patch and
> do testing.  For the time being, I'd prefer to stick with the single
> patch, since it is tested.

It shouldn't be hard to factor the patch into patches which produce the
identical end result, and are individually trivial enough to be unlikely
to break things partway through.

But the current patch isn't large enough that I'd put my foot down at
this point.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs