From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1IMCON-0008U9-Mx for user-mode-linux-devel@lists.sourceforge.net; Fri, 17 Aug 2007 17:42:16 -0700 Received: from saraswathi.solana.com ([198.99.130.12]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IMCON-00045h-7b for user-mode-linux-devel@lists.sourceforge.net; Fri, 17 Aug 2007 17:42:15 -0700 Date: Fri, 17 Aug 2007 15:43:42 -0400 From: Jeff Dike Message-ID: <20070817194342.GA8744@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Disposition: inline Subject: [uml-devel] [PATCH 5/6] UML - Remove unneeded if from hostfs List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Andrew Morton Cc: Joe Perches , LKML , uml-devel , Satyam Sharma Get rid of an empty if statement which might look like a bug to a casual reader. Signed-off-by: Jeff Dike -- fs/hostfs/hostfs_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/fs/hostfs/hostfs_user.c =================================================================== --- linux-2.6.22.orig/fs/hostfs/hostfs_user.c 2007-08-17 13:36:34.000000000 -0400 +++ linux-2.6.22/fs/hostfs/hostfs_user.c 2007-08-17 13:37:45.000000000 -0400 @@ -283,7 +283,7 @@ int set_attr(const char *file, struct ho } } - if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; + /* Note: ctime is not handled */ if(attrs->ia_valid & (HOSTFS_ATTR_ATIME | HOSTFS_ATTR_MTIME)){ err = stat_file(file, NULL, NULL, NULL, NULL, NULL, NULL, &attrs->ia_atime, &attrs->ia_mtime, NULL, ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760773AbXHRAom (ORCPT ); Fri, 17 Aug 2007 20:44:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760230AbXHRAm4 (ORCPT ); Fri, 17 Aug 2007 20:42:56 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:57752 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759650AbXHRAmz (ORCPT ); Fri, 17 Aug 2007 20:42:55 -0400 Date: Fri, 17 Aug 2007 15:43:42 -0400 From: Jeff Dike To: Andrew Morton Cc: LKML , uml-devel , Joe Perches , Satyam Sharma Subject: [PATCH 5/6] UML - Remove unneeded if from hostfs Message-ID: <20070817194342.GA8744@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Get rid of an empty if statement which might look like a bug to a casual reader. Signed-off-by: Jeff Dike -- fs/hostfs/hostfs_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.22/fs/hostfs/hostfs_user.c =================================================================== --- linux-2.6.22.orig/fs/hostfs/hostfs_user.c 2007-08-17 13:36:34.000000000 -0400 +++ linux-2.6.22/fs/hostfs/hostfs_user.c 2007-08-17 13:37:45.000000000 -0400 @@ -283,7 +283,7 @@ int set_attr(const char *file, struct ho } } - if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; + /* Note: ctime is not handled */ if(attrs->ia_valid & (HOSTFS_ATTR_ATIME | HOSTFS_ATTR_MTIME)){ err = stat_file(file, NULL, NULL, NULL, NULL, NULL, NULL, &attrs->ia_atime, &attrs->ia_mtime, NULL,