Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Saturday 11 August 2007, Sergei Shtylyov wrote:
> Hello, I wrote:
> 
> >>  101 files changed, 1880 insertions(+), 2828 deletions(-)
> 
> >> please look at -mm or IDE quilt tree instead. :)
> 
> >    Looking...
> 
>     When are you planning to push out to Linus the 
> ide-mode-limiting-fixes-for-user-requested-speed-changes.patch? I'd like my 
> HPT37x SATA mode filtering stuff to be atop of this one, after looking at it.

Preferably 2.6.24 material and ide_rate_filter() FIXME (respecting device PIO
limits) still needs to be addressed before pushing all mode limiting patches
upstream.

> >> ide_rate_filter() happily uses ide_find_dma_mode() nowadays (however this
> >> hpt366 patch is for vanilla kernel which doesn't have the needed 
> >> changes).
> 
>     Yeah, it keeps being in the same vein (same bug rather :-) as the old 
> code, i.e. not looking at hwif->mwdma_mask when falling back in 
> ide_rate_filter()...

Worth fixing but deserves a separate patch.

Bart