All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Roland McGrath <roland@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] exec: kill unsafe BUG_ON(sig->count) checks
Date: Sat, 18 Aug 2007 15:33:52 -0700	[thread overview]
Message-ID: <20070818223352.GG7628@linux.vnet.ibm.com> (raw)
In-Reply-To: <20070818173936.GA206@tv-sign.ru>

On Sat, Aug 18, 2007 at 09:39:36PM +0400, Oleg Nesterov wrote:
> de_thread:
> 
> 	if (atomic_read(&oldsighand->count) <= 1)
> 		BUG_ON(atomic_read(&sig->count) != 1);
> 
> This is not safe without the rmb() in between. The results of two correctly
> ordered __exit_signal()->atomic_dec_and_test()'s could be seen out of order
> on our CPU.
> 
> The same is true for the "thread_group_empty()" case, __unhash_process()'s
> changes could be seen before atomic_dec_and_test(&sig->count).
> 
> On some platforms (including i386) atomic_read() doesn't provide even the
> compiler barrier, in that case these checks are simply racy.
> 
> Remove these BUG_ON()'s. Alternatively, we can do something like
> 
> 	BUG_ON( ({ smp_rmb(); atomic_read(&sig->count) != 1; }) );

Good catches!

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
> 
> --- t/fs/exec.c~1_BUG_ON	2007-08-18 17:36:58.000000000 +0400
> +++ t/fs/exec.c	2007-08-18 18:19:41.000000000 +0400
> @@ -784,7 +784,6 @@ static int de_thread(struct task_struct 
>  	 * and we can just re-use it all.
>  	 */
>  	if (atomic_read(&oldsighand->count) <= 1) {
> -		BUG_ON(atomic_read(&sig->count) != 1);
>  		signalfd_detach(tsk);
>  		exit_itimers(sig);
>  		return 0;
> @@ -929,8 +928,6 @@ no_thread_group:
>  	if (leader)
>  		release_task(leader);
> 
> -	BUG_ON(atomic_read(&sig->count) != 1);
> -
>  	if (atomic_read(&oldsighand->count) == 1) {
>  		/*
>  		 * Now that we nuked the rest of the thread group,
> 

  reply	other threads:[~2007-08-18 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-18 17:39 [PATCH 1/5] exec: kill unsafe BUG_ON(sig->count) checks Oleg Nesterov
2007-08-18 22:33 ` Paul E. McKenney [this message]
2007-08-18 23:27 ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070818223352.GG7628@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.