From: David Brownell <david-b@pacbell.net>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrdiff_t is not uintptr_t, damnit
Date: Sun, 19 Aug 2007 17:57:56 -0700 [thread overview]
Message-ID: <200708191757.56520.david-b@pacbell.net> (raw)
In-Reply-To: <E83C36D0-B72E-4E70-BEF6-4AF54BAD2863@cam.ac.uk>
On Sunday 19 August 2007, Anton Altaparmakov wrote:
> >
> > ISTR we don't *have* a uintptr_t on all architectures, or that would
> > be the appropriate thing to use in these 32/64 bit ABI scenarios.
> >
> >
> >> Use unsigned long or uintptr_t instead.
> >
> > I suspect you mean "unsigned long long"...
>
> No he doesn't. "unsigned long" is guaranteed to be large enough to
> hold a pointer (at least on Linux anyway).
And yet when I used that, I got compiler warnings on some systems.
ISTR that was the first solution I tried, but GCC really wanted to
issue warnings. Either about casting 64-bit to pointer, or about
casting it to "unsigned long", either way lost precision.
> On a 32-bit arch "unsigned long" is 32-bit and pointers are 32-bit.
>
> On a 64-bit archi "unsigned long" is 64-bit and pointers are 64-bit.
So with 32 bit userspace "unsigned long long" is the type to use
when talking to a 64-bit kernel; and with pure 64-bit code, it's
enough to write "unsigned long".
I'm fairly sure that's the root cause of the pain I recall here;
but I'd have to run experiments again to verify that.
next prev parent reply other threads:[~2007-08-20 0:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-19 22:55 [PATCH] ptrdiff_t is not uintptr_t, damnit Al Viro
2007-08-20 0:19 ` David Brownell
2007-08-20 0:29 ` Anton Altaparmakov
2007-08-20 0:57 ` Al Viro
2007-08-20 0:57 ` David Brownell [this message]
2007-08-20 3:01 ` Satyam Sharma
2007-08-20 3:26 ` David Brownell
2007-08-20 3:40 ` Al Viro
2007-08-20 4:17 ` David Brownell
2007-08-20 0:27 ` Anton Altaparmakov
2007-08-20 0:52 ` Al Viro
2007-08-20 1:12 ` David Brownell
2007-08-21 18:53 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708191757.56520.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=aia21@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.