From: David Brownell <david-b@pacbell.net>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: a.zummo@towertech.it, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com, ralf@linux-mips.org
Subject: Re: [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)
Date: Sun, 19 Aug 2007 18:49:16 -0700 [thread overview]
Message-ID: <200708191849.16648.david-b@pacbell.net> (raw)
In-Reply-To: <20070819.223210.21590535.anemo@mba.ocn.ne.jp>
On Sunday 19 August 2007, Atsushi Nemoto wrote:
> The rtc-rs5c348 SPI driver name doesn't match its module name, which
> prevents it from properly hotplugging. There is only one in-tree user
> of its driver, which is fixed by this patch too.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
ACK.
> ---
> arch/mips/tx4938/toshiba_rbtx4938/setup.c | 2 +-
> drivers/rtc/rtc-rs5c348.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/tx4938/toshiba_rbtx4938/setup.c b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> index 57f3c70..84ebff7 100644
> --- a/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> +++ b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> @@ -1115,7 +1115,7 @@ static void __init txx9_spi_init(unsigned long base, int irq)
> static int __init rbtx4938_spi_init(void)
> {
> struct spi_board_info srtc_info = {
> - .modalias = "rs5c348",
> + .modalias = "rtc-rs5c348",
> .max_speed_hz = 1000000, /* 1.0Mbps @ Vdd 2.0V */
> .bus_num = 0,
> .chip_select = 16 + SRTC_CS,
> diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
> index f50f3fc..8394626 100644
> --- a/drivers/rtc/rtc-rs5c348.c
> +++ b/drivers/rtc/rtc-rs5c348.c
> @@ -226,7 +226,7 @@ static int __devexit rs5c348_remove(struct spi_device *spi)
>
> static struct spi_driver rs5c348_driver = {
> .driver = {
> - .name = "rs5c348",
> + .name = "rtc-rs5c348",
> .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
>
next prev parent reply other threads:[~2007-08-20 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-19 13:32 [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2) Atsushi Nemoto
2007-08-20 1:49 ` David Brownell [this message]
2007-08-20 10:44 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708191849.16648.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=a.zummo@towertech.it \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.